Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-61850: Focus & Offline handling #32176

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vmenshutin-bylight
Copy link
Contributor

@vmenshutin-bylight vmenshutin-bylight commented Sep 30, 2024

Summary

This is a follow up of #32100

Removed auto focus from the spinner and made sure the focus stays on the PrintDownloadButton after the download attempt (both error and successful).

Added special error treatment to PrintDownloadButton in case there is no network.

Related issue(s)

https://jira.devops.va.gov/browse/MHV-61850

image

Testing done

  • Manual testing

What areas of the site does it impact?

/my-health/medications

Acceptance criteria

AC1: Work is validated by accessibility
AC2: Focus should remain on the dropdown button in a closed state after selecting to download a page/record
AC3: Check other pages to make sure it is working properly on those.

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

rmessina1010
rmessina1010 previously approved these changes Oct 1, 2024
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmenshutin-bylight vmenshutin-bylight force-pushed the MHV-61349-focus-and-offline-handling branch from 9a36dab to ec99738 Compare October 1, 2024 13:35
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-61349-focus-and-offline-handling/main October 1, 2024 13:46 Inactive
robertbylight
robertbylight previously approved these changes Oct 1, 2024
@vmenshutin-bylight vmenshutin-bylight force-pushed the MHV-61349-focus-and-offline-handling branch from a892781 to ee73c5c Compare October 1, 2024 17:49
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-61349-focus-and-offline-handling/main October 1, 2024 18:04 Inactive
@vmenshutin-bylight vmenshutin-bylight force-pushed the MHV-61349-focus-and-offline-handling branch from ee73c5c to a55c6e2 Compare October 2, 2024 13:57
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-61349-focus-and-offline-handling/main October 2, 2024 14:08 Inactive
@vmenshutin-bylight vmenshutin-bylight changed the title MHV-61349: Focus & Offline handling MHV-61850: Focus & Offline handling Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants