-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHV-61850: Focus & Offline handling #32176
Open
vmenshutin-bylight
wants to merge
7
commits into
main
Choose a base branch
from
MHV-61349-focus-and-offline-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/MHV-61349-focus-and-offline-handling/main
September 30, 2024 22:41
Inactive
rmessina1010
previously approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vmenshutin-bylight
force-pushed
the
MHV-61349-focus-and-offline-handling
branch
from
October 1, 2024 13:35
9a36dab
to
ec99738
Compare
va-vfs-bot
temporarily deployed
to
master/MHV-61349-focus-and-offline-handling/main
October 1, 2024 13:46
Inactive
robertbylight
previously approved these changes
Oct 1, 2024
RajiVenkatesh18
dismissed stale reviews from robertbylight and rmessina1010
via
October 1, 2024 17:47
a892781
vmenshutin-bylight
force-pushed
the
MHV-61349-focus-and-offline-handling
branch
from
October 1, 2024 17:49
a892781
to
ee73c5c
Compare
va-vfs-bot
temporarily deployed
to
master/MHV-61349-focus-and-offline-handling/main
October 1, 2024 18:04
Inactive
vmenshutin-bylight
force-pushed
the
MHV-61349-focus-and-offline-handling
branch
from
October 2, 2024 13:57
ee73c5c
to
a55c6e2
Compare
va-vfs-bot
temporarily deployed
to
master/MHV-61349-focus-and-offline-handling/main
October 2, 2024 14:08
Inactive
added assertion to validate focus on print or download button after download
vmenshutin-bylight
force-pushed
the
MHV-61349-focus-and-offline-handling
branch
from
October 2, 2024 15:08
151921a
to
8890cb7
Compare
vmenshutin-bylight
changed the title
MHV-61349: Focus & Offline handling
MHV-61850: Focus & Offline handling
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up of #32100
Removed auto focus from the spinner and made sure the focus stays on the
PrintDownloadButton
after the download attempt (both error and successful).Added special error treatment to
PrintDownloadButton
in case there is no network.Related issue(s)
https://jira.devops.va.gov/browse/MHV-61850
Testing done
What areas of the site does it impact?
/my-health/medications
Acceptance criteria
AC1: Work is validated by accessibility
AC2: Focus should remain on the dropdown button in a closed state after selecting to download a page/record
AC3: Check other pages to make sure it is working properly on those.
Quality Assurance & Testing
Error Handling
Authentication